lib: unexpose six process bindings

Namely: async_wrap, crypto, http_parser, signal_wrap, url, and v8. They were runtime-deprecated 4 years ago. PR-URL: nodejs#57149 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
geeksilva97 · Feb 25, 2025 · c864dea · c864dea
1 parent 6cb0690
commit c864dea
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 23 deletions.
diff --git a/lib/internal/bootstrap/realm.js b/lib/internal/bootstrap/realm.js
@@ -112,12 +112,7 @@ const processBindingAllowList = new SafeSet([
 ]);
 
 const runtimeDeprecatedList = new SafeSet([
-  'async_wrap',
-  'crypto',
-  'http_parser',
-  'signal_wrap',
-  'url',
-  'v8',
+  // The list of runtime-deprecated bindings is currently empty.
 ]);
 
 const legacyWrapperList = new SafeSet([

diff --git a/test/fixtures/permission/processbinding.js b/test/fixtures/permission/processbinding.js
@@ -15,14 +15,6 @@ const assert = require('assert');
   }));
 }
 
-{
-  assert.throws(() => {
-    process.binding('async_wrap');
-  }, common.expectsError({
-    code: 'ERR_ACCESS_DENIED',
-  }));
-}
-
 {
   assert.throws(() => {
     process.binding('fs');

diff --git a/test/parallel/test-http-parser-timeout-reset.js b/test/parallel/test-http-parser-timeout-reset.js
@@ -1,8 +1,10 @@
+// Flags: --expose-internals
 'use strict';
 const common = require('../common');
 
 const net = require('net');
-const { HTTPParser } = process.binding('http_parser');
+const { internalBinding } = require('internal/test/binding');
+const { HTTPParser } = internalBinding('http_parser');
 
 const server = net.createServer((socket) => {
   socket.write('HTTP/1.1 200 OK\r\n');

diff --git a/test/parallel/test-process-binding-internalbinding-allowlist.js b/test/parallel/test-process-binding-internalbinding-allowlist.js
@@ -6,17 +6,12 @@ const assert = require('assert');
 
 // Assert that allowed internalBinding modules are accessible via
 // process.binding().
-assert(process.binding('async_wrap'));
 assert(process.binding('buffer'));
 assert(process.binding('cares_wrap'));
 assert(process.binding('constants'));
 assert(process.binding('contextify'));
-if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
-  assert(process.binding('crypto'));
-}
 assert(process.binding('fs'));
 assert(process.binding('fs_event_wrap'));
-assert(process.binding('http_parser'));
 if (common.hasIntl) {
   assert(process.binding('icu'));
 }
@@ -25,7 +20,6 @@ assert(process.binding('js_stream'));
 assert(process.binding('natives'));
 assert(process.binding('os'));
 assert(process.binding('pipe_wrap'));
-assert(process.binding('signal_wrap'));
 assert(process.binding('spawn_sync'));
 assert(process.binding('stream_wrap'));
 assert(process.binding('tcp_wrap'));
@@ -34,8 +28,6 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
 }
 assert(process.binding('tty_wrap'));
 assert(process.binding('udp_wrap'));
-assert(process.binding('url'));
 assert(process.binding('util'));
 assert(process.binding('uv'));
-assert(process.binding('v8'));
 assert(process.binding('zlib'));