update: inertia benefit from caching + move from pkg_resources to importlib.metada #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneiderfelipe
force-pushed
the
main
branch
from
6870dab to
5036edf
Compare
schneiderfelipe
force-pushed
the
main
branch
from
5036edf to
bcce554
Compare
schneiderfelipe
force-pushed
the
main
branch
2 times, most recently
from
46507cc to
e72d420
Compare
m-rauen
commented
Jan 29, 2025
|
|
||
| import numpy as np | ||
| from scipy.stats import cauchy, norm | ||
|
|
||
| import overreact as rx | ||
| from overreact import _constants as constants | ||
|
|
||
| def make_hashable(obj): |
There was a problem hiding this comment.
I forget to add the python function annotations here and in the copy_unhashable() function. I will add this piece and send a new PR asap
m-rauen
commented
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the setuptools page, using
pkg_resourcesis deprecated in favor ofimportlib. Therefore, I took the initiative to change it.I noticed that inertia moment can benefit from cache strategy and decided to implement it. Cache requires hashable objects and arrays/numpy arrays aren't. So, I decided to create a prototype of those arrays, make them hashable and introduce cache, while passing the same array to the function and not generating errors.
I also changed the jax callout, as it's already resolved in #713.