Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for DNS install method #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danmoz
Copy link

@danmoz danmoz commented Feb 6, 2024

This PR implements support for the DNS install method (#186). Any provider specific configuration is considered out of scope; I updated the docs to describe how to achieve this using standard Ansible functionality. As a result, there are minimal changes required.

@danmoz danmoz force-pushed the dns-cert-creation branch from 82d799d to ce3240e Compare February 6, 2024 05:44
@tgeorgel
Copy link

Hey,
Thanks for this PR, I'm currently testing it :)

I was checking the README, and I don't think the certbot_create_extra_args var is actually used in the certbot_create_command var.

@tgeorgel
Copy link

Hey, Thanks for this PR, I'm currently testing it :)

I was checking the README, and I don't think the certbot_create_extra_args var is actually used in the certbot_create_command var.

Nevermind, it's just me being blind :-)

Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Jun 24, 2024
@danmoz
Copy link
Author

danmoz commented Jun 24, 2024

Hi! PR author here. Thanks for the link to the blog post, I can surely empathise with your reluctance to provide unpaid code review. However I was wondering if you'd reconsider your decision on this occasion given that:

  • Without the DNS method, wildcard cert generation is quite difficult
  • Interest in this feature has been expressed in previous issues and PRs
  • You've expressed an interest in this feature, if it was implemented in a simple way (to paraphrase)
  • The implementation in this PR is pretty minimal, most of the changes are to documentation

FWIW, I've been using this code to generate and wildcard certs in production for the past few months and I've not encountered any issues. Thanks for your consideration, and for a great Ansible role.

@github-actions github-actions bot removed the stale label Jul 1, 2024
Copy link

github-actions bot commented Nov 4, 2024

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants