-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for DNS install method #207
base: master
Are you sure you want to change the base?
Conversation
82d799d
to
ce3240e
Compare
…roach won't work for cron job updates
Hey, I was checking the README, and I don't think the |
Nevermind, it's just me being blind :-) |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
Hi! PR author here. Thanks for the link to the blog post, I can surely empathise with your reluctance to provide unpaid code review. However I was wondering if you'd reconsider your decision on this occasion given that:
FWIW, I've been using this code to generate and wildcard certs in production for the past few months and I've not encountered any issues. Thanks for your consideration, and for a great Ansible role. |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
This PR implements support for the DNS install method (#186). Any provider specific configuration is considered out of scope; I updated the docs to describe how to achieve this using standard Ansible functionality. As a result, there are minimal changes required.