Switch tests to use Molecule.

.gitignore

@@ -1,2 +1,3 @@
 *.retry
-tests/test.sh
+*/__pycache__
+*.pyc

.travis.yml

@@ -1,17 +1,27 @@
 ---
+language: python
 services: docker
 
 env:
-  - distro: centos7
-  - distro: ubuntu1604
+  global:
+    - ROLE_NAME: dotfiles
+  matrix:
+    - MOLECULE_DISTRO: centos7
+    - MOLECULE_DISTRO: ubuntu1804
 
-script:
-  # Download test shim.
-  - wget -O ${PWD}/tests/test.sh https://gist.githubusercontent.com/geerlingguy/73ef1e5ee45d8694570f334be385e181/raw/
-  - chmod +x ${PWD}/tests/test.sh
+install:
+  # Install test dependencies.
+  - pip install molecule docker
+
+before_script:
+  # Use actual Ansible Galaxy role name for the project directory.
+  - cd ../
+  - mv ansible-role-$ROLE_NAME geerlingguy.$ROLE_NAME
+  - cd geerlingguy.$ROLE_NAME
 
+script:
   # Run tests.
-  - ${PWD}/tests/test.sh
+  - molecule test
 
 notifications:
   webhooks: https://galaxy.ansible.com/api/v1/notifications/

README.md

@@ -16,7 +16,7 @@ Available variables are listed below, along with default values (see `defaults/m
 
 The git repository to use for retrieving dotfiles. Dotfiles should generally be laid out within the root directory of the repository.
 
-    dotfiles_repo_accept_hostkey: no
+    dotfiles_repo_accept_hostkey: false
 
 Add the hostkey for the repo url if not already added. If ssh_opts contains "-o StrictHostKeyChecking=no", this parameter is ignored.
 

defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 dotfiles_repo: "https://github.com/geerlingguy/dotfiles.git"
-dotfiles_repo_accept_hostkey: no
+dotfiles_repo_accept_hostkey: false
 dotfiles_repo_local_destination: "~/Documents/dotfiles"
 
 dotfiles_home: "~"

meta/main.yml

@@ -8,18 +8,20 @@ galaxy_info:
   license: "license (BSD, MIT)"
   min_ansible_version: 2.2
   platforms:
-  - name: GenericUNIX
-    versions:
-      - all
-      - any
-  - name: GenericBSD
-    versions:
-      - all
-      - any
-  - name: GenericLinux
-    versions:
-      - all
-      - any
+    - name: GenericUNIX
+      versions:
+        - all
+        - any
+    - name: GenericBSD
+      versions:
+        - all
+        - any
+    - name: GenericLinux
+      versions:
+        - all
+        - any
   galaxy_tags:
     - development
     - system
+    - dotfiles
+    - configuration

molecule/default/molecule.yml

@@ -0,0 +1,27 @@
+---
+dependency:
+  name: galaxy
+driver:
+  name: docker
+lint:
+  name: yamllint
+  options:
+    config-file: molecule/default/yaml-lint.yml
+platforms:
+  - name: instance
+    image: geerlingguy/docker-${MOLECULE_DISTRO:-centos7}-ansible
+    command: ${MOLECULE_DOCKER_COMMAND:-"sleep infinity"}
+    privileged: true
+    pre_build_image: true
+provisioner:
+  name: ansible
+  lint:
+    name: ansible-lint
+  playbooks:
+    converge: ${MOLECULE_PLAYBOOK:-playbook.yml}
+scenario:
+  name: default
+verifier:
+  name: testinfra
+  lint:
+    name: flake8

tests/test.yml → molecule/default/playbook.yml

@@ -1,11 +1,13 @@
 ---
-- hosts: all
+- name: Converge
+  hosts: all
+  become: true
 
   pre_tasks:
     - name: Update apt cache.
       apt: update_cache=yes cache_valid_time=600
       when: ansible_os_family == 'Debian'
 
   roles:
-    - geerlingguy.git
-    - role_under_test
+    - role: geerlingguy.git
+    - role: geerlingguy.dotfiles

molecule/default/tests/test_default.py

@@ -0,0 +1,14 @@
+import os
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+    os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all')
+
+
+def test_hosts_file(host):
+    f = host.file('/etc/hosts')
+
+    assert f.exists
+    assert f.user == 'root'
+    assert f.group == 'root'

molecule/default/yaml-lint.yml

@@ -0,0 +1,6 @@
+---
+extends: default
+rules:
+  line-length:
+    max: 120
+    level: warning

tasks/main.yml

@@ -4,13 +4,13 @@
     repo: "{{ dotfiles_repo }}"
     dest: "{{ dotfiles_repo_local_destination }}"
     accept_hostkey: "{{ dotfiles_repo_accept_hostkey }}"
-  become: no
+  become: false
 
 - name: Ensure all configured dotfiles are links.
   shell: "ls -F {{ dotfiles_home }}/{{ item }}"
   register: existing_dotfile_info
   failed_when: false
-  check_mode: no
+  check_mode: false
   changed_when: false
   with_items: "{{ dotfiles_files }}"
 
@@ -26,5 +26,5 @@
     src: "{{ dotfiles_repo_local_destination }}/{{ item }}"
     dest: "{{ dotfiles_home }}/{{ item }}"
     state: link
-  become: no
+  become: false
   with_items: "{{ dotfiles_files }}"