-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow directory trees in dotfiles lists #13
Conversation
I already opened up a PR for this #12. That PR doesn't have |
It is not strictly speaking necessary, but it does allow you to have links
to subdirectories instead of subdirectories, if you pre-create them.
…On Wed, May 31, 2017 at 6:55 AM, Oskar Schöldström ***@***.*** > wrote:
I already opened up a PR for this #12
<#12>. That PR
doesn't have follow: yes though. Is it necessary?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA8_bItMlJyX4qlD1eSd072bkdkquKlks5r_XFFgaJpZM4NanIT>
.
|
@yn you should add I can then close my PR and try and poke @geerlingguy to see if he can merge this :) |
@oxyc done |
Would also love to see this get merged! 😄 cc @geerlingguy ...anything in particular preventing this from happening? Happy to help if I can. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
would love to see this merged |
@geerlingguy any chance to get this still merged? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple quick fixes for linting.
Wow, I didn't expect such a fast response. Thanks a lot for your work! |
Heh, honestly this PR just slipped through the cracks. Glad you brought it back up :) |
Hmm... after merging this in, I spotted an error in my mac-dev-playbook's CI run: https://github.com/geerlingguy/mac-dev-playbook/actions/runs/12173583322
|
Consider a directory tree layout in dotfiles layout like this:
The current codebase supports this in a fairly straightforward manner, except it doesn't create parent directories like
.ssh
This PR fixes that by adding a play that creates parent directories.