Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow directory trees in dotfiles lists #13

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

yn
Copy link
Contributor

@yn yn commented May 15, 2017

Consider a directory tree layout in dotfiles layout like this:

dotfiles_files:
  - .gitconfig
  - .gitignore_global
  - .ssh/config

The current codebase supports this in a fairly straightforward manner, except it doesn't create parent directories like .ssh

This PR fixes that by adding a play that creates parent directories.

@oxyc
Copy link

oxyc commented May 31, 2017

I already opened up a PR for this #12. That PR doesn't have follow: yes though. Is it necessary?

@yn
Copy link
Contributor Author

yn commented Jun 6, 2017 via email

@oxyc
Copy link

oxyc commented Feb 27, 2018

@yn you should add become: no as well (geerlingguy often uses become:yes in the main playbook).

I can then close my PR and try and poke @geerlingguy to see if he can merge this :)

@yn
Copy link
Contributor Author

yn commented Mar 16, 2018

@oxyc done

@cbracco
Copy link

cbracco commented Dec 29, 2018

Would also love to see this get merged! 😄 cc @geerlingguy ...anything in particular preventing this from happening? Happy to help if I can.

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Apr 5, 2020
@tgallacher
Copy link

would love to see this merged

@jaulz
Copy link

jaulz commented Dec 4, 2024

@geerlingguy any chance to get this still merged? 😊

@geerlingguy geerlingguy reopened this Dec 4, 2024
Copy link
Owner

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick fixes for linting.

tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
@geerlingguy geerlingguy merged commit fa83421 into geerlingguy:master Dec 4, 2024
3 checks passed
@jaulz
Copy link

jaulz commented Dec 4, 2024

Wow, I didn't expect such a fast response. Thanks a lot for your work! ☺️

@geerlingguy
Copy link
Owner

Heh, honestly this PR just slipped through the cracks. Glad you brought it back up :)

@geerlingguy
Copy link
Owner

Hmm... after merging this in, I spotted an error in my mac-dev-playbook's CI run: https://github.com/geerlingguy/mac-dev-playbook/actions/runs/12173583322

TASK [Run .osx dotfiles.] ******************************************************
fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/Users/runner/.osx --no-restart", "msg": "[Errno 13] Permission denied: b'/Users/runner/.osx'", "rc": 13, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants