Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the configuration of any opcache variable #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpiron
Copy link

@jpiron jpiron commented May 15, 2024

This removes the need to update the role to support new opcache variables.

@shakalandy
Copy link
Contributor

Cool, this would make my PR #416 obsolete, but keep the default, right?

@jpiron jpiron force-pushed the feat/opcache_any_variable branch from 02f5653 to 8b47e73 Compare May 16, 2024 05:02
@jpiron
Copy link
Author

jpiron commented May 16, 2024

Yes, except for the php_realpath_cache_ttl variable.
And indeed it keeps all the defaults as long as you don't define the php_opcache_* variables.
I updated the README to make it more clear.

@shakalandy
Copy link
Contributor

@geerlingguy could we get this one merged? I would adapt #416 to include php_realpath_cache_ttl only - thanks!

Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Sep 14, 2024
@jpiron jpiron force-pushed the feat/opcache_any_variable branch from 8b47e73 to 8bc92a5 Compare September 16, 2024 10:13
@github-actions github-actions bot removed the stale label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants