Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more handlers #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more handlers #26

wants to merge 2 commits into from

Conversation

mxmehl
Copy link

@mxmehl mxmehl commented Oct 19, 2020

This PR adds a few more handlers which may be useful in some scenarios.

@gekmihesg
Copy link
Owner

Sure, but using the nohup module on those isn't really needed. I did that on the others, because they are very likely to break the network connection to the Ansible controller which would cause errors. Those you've added look safe to directly use uci or service instead.

gekmihesg
gekmihesg requested changes Apr 17, 2021
View reviewed changes
handlers/main.yml
@@ -28,3 +28,21 @@
- setup wifi
- reload wifi
- restart network

- name: uci commit
nohup:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use uci directly here

handlers/main.yml
when: "'openwrt' in group_names"

- name: restart firewall
nohup:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use service

handlers/main.yml
when: "'openwrt' in group_names"

- name: reload system
nohup:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use service

@donatengit donatengit mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gekmihesg gekmihesg gekmihesg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmehl @gekmihesg