Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tempfile module #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

s-hamann
Copy link
Contributor

I implemented the tempfile module.
It works mostly like Ansible's reference implementation with the exception of the suffix parameter. This parameter is ignored here, because BusyBox mktemp does not support a suffix.
As a workaround, I considered renaming the file/directory to add the suffix, but found that to be difficult to check without creating a race condition.

@Jonny007-MKD
Copy link

did you consider writing a test? From the readme:

Writing tests for your new module is also highly recommended.

@s-hamann
Copy link
Contributor Author

Yes, tests would make sense. I'll see if I can find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants