Add a FastAPI + Gel AI tutorial app #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diksipav
reviewed
Feb 4, 2025
| using extension ai; | ||
|
|
||
| module default { | ||
| type Message { |
There was a problem hiding this comment.
is it better to annotate some of the props as required? also the Chat can have required multi Message?
There was a problem hiding this comment.
The Chat is empty when it's created, so messages can't be required. It'd make sense for the User.name to be required, agreed. As for the rest of the properties, I would prefer to leave them as is, since there's no actual downstream application that would drive those constraints.
elprans
approved these changes
Feb 5, 2025
| @@ -0,0 +1 @@ | |||
| 3.13 | |||
There was a problem hiding this comment.
It's used by uv to pin the Python version: link to docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft on the LLM-powered search app that remembers interactions with the user and references them when answering new questions.