docs: improve assertView docs #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kabir-Ivan
force-pushed
the
add-assert-viewport-docs
branch
from
501d715 to
fe1177a
Compare
✅ Successfully deployed static |
shadowusr
approved these changes
Aug 12, 2024
docs/commands/browser/assertView.mdx
Outdated
| @@ -24,7 +25,7 @@ await browser.assertView(state, selector, options); | |||
| </thead> | |||
| <tbody> | |||
| <tr><td>[state](#state)</td><td>String</td><td>Обязательный параметр. Название состояния теста. Должно быть уникальным в пределах одного теста.</td></tr> | |||
| <tr><td>[selector](#selector)</td><td>String или String[]</td><td>Обязательный параметр. Селектор DOM-элемента, который необходимо заснять.</td></tr> | |||
| <tr><td>[selector](#selector)</td><td>String или String[]</td><td>Необязательный параметр. Может быть пропущен. Селектор DOM-элемента, который необходимо заснять.</td></tr> | |||
There was a problem hiding this comment.
Let's leave a note right here that if omitted, the whole viewport will be screenshotted
docs/commands/browser/assertView.mdx
Outdated
| @@ -159,9 +168,22 @@ it("should assert view", async ({ browser }) => { | |||
| }); | |||
| ``` | |||
|
|
|||
| **example-2.js** | |||
| **example-2.ts** | |||
There was a problem hiding this comment.
Let's give this heading a human readable form. Like "Визуальная проверка всего вьюпорта" or something like that.
Kabir-Ivan
force-pushed
the
add-assert-viewport-docs
branch
from
7c6c8d5 to
c14840b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.