feat: implement responsive landing page #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
commented
Jun 9, 2024
| }, | ||
| }), | ||
| { | ||
| rootMargin: "100% 0% -10% 0%", |
There was a problem hiding this comment.
How it works: https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver/rootMargin
Basically this defines at what point the element should be considered visible.
✅ Successfully deployed static |
shadowusr
commented
Jun 9, 2024
shadowusr
commented
Jun 9, 2024
shadowusr
commented
Jun 9, 2024
shadowusr
commented
Jun 9, 2024
KuznetsovRoman
approved these changes
Jun 10, 2024
sipayRT
approved these changes
Jun 11, 2024
Fonts won't flicker if you have cache turned on. On the first page load yeah, it's quite impossible to completely get rid of FOUT. I suggest to look into this later, cause right now I see no straightforward way to reduce flickering — especially since fallback fonts are different on different platforms and optimising it for one will hurt the other OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a responsive landing page for Testplane docs.
The most convenient way to review would be to open this PR in codespaces and start from
pages/index.tsx, following all of its dependencies.I've added comments to make review process a bit easier.