Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double initialization #15

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Double initialization #15

merged 6 commits into from
Mar 19, 2024

Conversation

adrienbanse
Copy link
Member

@adrienbanse adrienbanse requested a review from samuelrince March 19, 2024 13:35
@adrienbanse
Copy link
Member Author

I'm not sure if there is a workaround that allows not to export TracerInitializationError in __init__.py to use it in the tests
We can also just check if it raises an Exception

@samuelrince
Copy link
Member

samuelrince commented Mar 19, 2024

Looks great!

I'm not sure if there is a workaround that allows not to export TracerInitializationError in __init__.py to use it in the tests We can also just check if it raises an Exception

Can't you just import it with from genai_impact.tracer import TracerInitializationError?

Also, not mandatory, but I find it to be a good practice to centralize the possible exceptions of the package in a separate module called exceptions.py. And have a global exception GenAIImpactError that is inherited by all the other exceptions.

PS: I can't wait to change the name, it makes my eyes bleed to see GenAIImpact in the class names!

@adrienbanse
Copy link
Member Author

@samuelrince Right! Yes it's not the optimal naming haha
It's implemented

@samuelrince samuelrince merged commit 1316e3a into main Mar 19, 2024
1 check passed
@samuelrince samuelrince deleted the feat/tracer_init branch March 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants