-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Decidim to v0.27 #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test? can we document exactly what are we changing from the original class?
Can we use a decorator instead of overriding the whole class?
def url | ||
Decidim::ResourceLocatorPresenter.new(process).url&.split("?")&.first | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document why we need this? Process URLs don't have query parameters no?
...extended/app/serializers/decidim/participatory_processes/participatory_process_serializer.rb
Outdated
Show resolved
Hide resolved
…s_loaded_massively
…s_loaded_massively
…oses_loaded_massively Feat/unified notification on proposes loaded massively
26a0345
to
0771a6a
Compare
0771a6a
to
0fbbe6a
Compare
🎩 What? Why?
Upgrade Decidim to v0.27
Release notes: https://github.com/CodiTramuntana/decidim/blob/release/0.27-stable/CHANGELOG.md
In this version, participatory processes has type. We have a custom module for that (decidim-type) but is not necessary anymore, so we remove the custom module.
FIXES
Example in other modal
Fix
TO-DO
Related PRs:
📷 Screenshots (optional)