Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authors to proposals exportation #491

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Add authors to proposals exportation #491

merged 8 commits into from
Nov 13, 2024

Conversation

laurajaime
Copy link
Collaborator

@laurajaime laurajaime commented Jul 16, 2024 •
edited
Loading

🎩 What? Why?

Add authors name and emails to proposals exportation

📌 Related Issues

📋 Subtasks

  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

image

@laurajaime laurajaime requested a review from tramuntanal July 16, 2024 12:54
@laurajaime laurajaime force-pushed the add/author_in_export_proposals branch from cf9cb88 to f929991 Compare July 16, 2024 13:35
tramuntanal
tramuntanal requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one detail to minimize the overridden code

app/decorators/lib/decidim/proposals/proposal_serializer_decorator.rb Show resolved Hide resolved
@laurajaime laurajaime requested a review from tramuntanal July 17, 2024 15:47
tramuntanal
tramuntanal approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good @laurajaime !

tramuntanal
tramuntanal approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@laurajaime laurajaime merged commit cab1351 into master Nov 13, 2024
6 checks passed
@laurajaime laurajaime deleted the add/author_in_export_proposals branch November 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurajaime @tramuntanal