-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli option to allow running checks against a graphstore journal. #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.
I just want to confirm that the ->
operator is Java 8?
if (gocam.getAnnotations().stream().noneMatch(annotation ->
annotation.getProperty().getIRI().equals(graphType)
Noticing that tests did not pass? |
I will look at the tests—they are unfortunately sensitive to changing external data. |
Java 8! |
Test failure relates to website problems at biopax.org. Fix at #543. |
@kltm one thing to note—don't use this flag if testing the actual Minerva database. The models there don't have this annotation, which is inserted by the graphstore build. |
@balhoff Not that I was planning on changing the flags for our production Noctua stuff, but wouldn't that check be safe when looking at just a "TTL models only" store? |
@kltm in a TTL models only store, all of them would get skipped if you use that flag. They won't contain the triple |
@balhoff Ah, I think I understand: the trick is that they are marked in the "extended" store, but not so in the "noctua" one, and you're using that as the criteria? |
Yes. |
New CLI option
--check-graph-type
. Fixes #541.