adding ZFIN import models #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sierra-moxon From the diff, it looks like some manually created models will be deleted from Another thing is the return of the split contributor ORCID bug, which I'll point out in another comment. |
dustine32
reviewed
Apr 20, 2021
| "t", | ||
| "u", | ||
| "z" ; | ||
| dc:date "2009-05-14" ; |
There was a problem hiding this comment.
@sierra-moxon I see the weird split contributor bug has returned. Is this using the latest version of ontobio?
There was a problem hiding this comment.
@dustine32 - good catch - fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ZFIN models to master. I think the goal here, is to start running the pipeline with ZFIN imports at the beginning of May, after the May release (with the goal being to release these in the June release).
I'm adding this PR per suggestion from @kltm (as we are testing these models in a branch of the pipeline, issue-noctua-models-170-zfin-import-test).
fixes #170 (but shouldn't be merged without review from Seth and Dustin :)).
fixes #180
fixes #181