Make distributed session loading asynchronous to improve scalability … #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1195) * Introduce CustomRedisSessionStore to reduce excessive EXPIRE operations in Redis and improve session handling performance. Converted ProcessRestRequest method in GXRouting.cs to fully async implementation. * Ensures sessions load asynchronously * Apply suggestions from FAzzatto -Simplified exception handling by replacing await Task.FromException(ex) with throw -Refactored to throw PageNotFoundException directly when the route cannot be handled, removed unnecessary result task, and moved CommitSessionAsync() to a finally block for clearer async flow Removed CustomRedisSessionStore which was previously used as an experiment to reduce synchronous Redis Refresh calls. Now that LoadAsync is executed at the start of each request, those synchronous Refresh calls no longer appear to be necessary, because they were caused by the previous synchronous load. * Refactored method to remove the result variable and await tasks directly, preserving the original behavior. --------- Co-authored-by: claudiamurialdo <[email protected]> (cherry picked from commit bb22cbb) # Conflicts: # dotnet/src/dotnetcore/GxClasses.Web/Middleware/GXRouting.cs # dotnet/src/dotnetcore/GxNetCoreStartup/SessionHelper.cs # dotnet/src/dotnetcore/GxNetCoreStartup/Startup.cs # dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#1195)
Introduce CustomRedisSessionStore to reduce excessive EXPIRE operations in Redis and improve session handling performance. Converted ProcessRestRequest method in GXRouting.cs to fully async implementation.
Ensures sessions load asynchronously
Apply suggestions from FAzzatto -Simplified exception handling by replacing await Task.FromException(ex) with throw -Refactored to throw PageNotFoundException directly when the route cannot be handled, removed unnecessary result task, and moved CommitSessionAsync() to a finally block for clearer async flow
Removed CustomRedisSessionStore which was previously used as an experiment to reduce synchronous Redis Refresh calls. Now that LoadAsync is executed at the start of each request, those synchronous Refresh calls no longer appear to be necessary, because they were caused by the previous synchronous load.
Issue:206131