-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#81): conway update #82
Conversation
@@ -135,6 +100,39 @@ exceptionHandler = | |||
WH $ \case | |||
GYConversionException convErr → someBackendError $ tShow convErr | |||
GYQueryUTxOException txErr → someBackendError $ tShow txErr | |||
e@(GYBuildTxException buildErr) → case buildErr of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the special cases here could be covered by tests.
I don't see any test changes in this PR. I would expect to see some updated tests when such logic changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is largely governed by type system. There is no longer BuildTxException
, IIRC it's renamed to GYBuildTxError which no longer has Exception
instance so it cannot be thrown in first place. This GYBuildTxError
is now part of GYBuildTxException
and so there has been reordering of these error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.