feat(#111): allow SOR codebase to be used as library #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(#111): builds upon `facilitate-as-library-use` branch
sourabhxyz
changed the title
sourabhxyz
changed the title
sourabhxyz
commented
Oct 15, 2024
| @@ -12,6 +12,7 @@ module GeniusYield.OrderBot.Types | |||
| , OrderAssetPair (OAssetPair, currencyAsset, commodityAsset) | |||
| , OrderType (..) | |||
| , SOrderType (..) | |||
| , SOrderTypeI (..) | |||
There was a problem hiding this comment.
I defined this class for writing lookupBest function inside OrderBook.Extra module.
sourabhxyz
commented
Oct 15, 2024
Comment on lines
+24
to
+27
| , FillType (..) | ||
| , MatchExecutionInfo (..) | ||
| , completeFill | ||
| , partialFill |
There was a problem hiding this comment.
Not new definitions, but rather moved here from another module.
sourabhxyz
commented
Oct 15, 2024
| @@ -27,12 +27,20 @@ signature GeniusYield.OrderBot.OrderBook ( | |||
| -- * Order book construction | |||
| populateOrderBook, | |||
| buildOrderBookList, | |||
| emptyOrders, | |||
There was a problem hiding this comment.
New utilities to make strategy implementation agnostic of underlying orderbook implementation.
sourabhxyz
commented
Oct 15, 2024
| @@ -0,0 +1,49 @@ | |||
| {-| | |||
There was a problem hiding this comment.
Just moved contents of Main to this module instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111.