Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dummy change #34

Closed
wants to merge 1 commit into from
Closed

Added dummy change #34

wants to merge 1 commit into from

Conversation

4TT1L4
Copy link
Contributor

@4TT1L4 4TT1L4 commented Oct 13, 2023

Thank you for contributing to Smart Order Routers! We appreciate your effort and
dedication to improving this project. To ensure that your contribution is in line
with the project's guidelines and can be reviewed efficiently, please fill out
the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

Please provide a brief, concise summary of the changes in your pull request.
Explain the problem you are trying to solve and the solution you have implemented.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Testing

Please describe the tests you have added or modified, and provide any additional context or instructions needed to run the tests.

  • Test A
  • Test B

Additional Information

If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

@sourabhxyz
Copy link
Member

@4TT1L4 is this PR still relevant?

@4TT1L4
Copy link
Contributor Author

4TT1L4 commented Dec 15, 2023

@4TT1L4 is this PR still relevant?

No. This was just to trigger some builds and see how the docker layer caching is working.

But there is no need for further tests at the moment. We are confident now that it is working properly. I am closing this PR.

@4TT1L4 4TT1L4 closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants