Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for the removal of minFill #49

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Updates for the removal of minFill #49

merged 11 commits into from
Dec 14, 2023

Conversation

Micrograx
Copy link
Contributor

Thank you for contributing to Smart Order Routers! We appreciate your effort and
dedication to improving this project. To ensure that your contribution is in line
with the project's guidelines and can be reviewed efficiently, please fill out
the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

Please provide a brief, concise summary of the changes in your pull request.
Explain the problem you are trying to solve and the solution you have implemented.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

@Micrograx Micrograx requested a review from a team as a code owner November 2, 2023 21:43
sourabhxyz
sourabhxyz previously approved these changes Dec 10, 2023
Copy link
Member

@sourabhxyz sourabhxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourabhxyz sourabhxyz merged commit 7126000 into main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants