Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update README.md #61

merged 1 commit into from
Dec 18, 2023

Conversation

4TT1L4
Copy link
Contributor

@4TT1L4 4TT1L4 commented Dec 16, 2023

Summary

The link to the container registry was broken in the published doc version.

Reported via Discord:

Type of Change

Please mark the relevant option(s) for your pull request:

  • Documentation update (adding or updating documentation related to the project)

@4TT1L4 4TT1L4 requested a review from a team as a code owner December 16, 2023 12:36
@@ -135,7 +135,7 @@ using these `20 tokenB` we can get `10 tokenA` from the buy order, earning `2 to

### Running the SOR using Docker

A ready-to-run, containerized version of the Smart Order Router is available via the [GitHub Container Registry](ghcr.io/geniusyield/smart-order-router:latest).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://github.com/geniusyield/smart-order-router/pkgs/container/smart-order-router there is a link under "Running the SOR using Docker" called GitHub Container Registry.

This is broken. So this must be fixed.

Copy link
Member

@sourabhxyz sourabhxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourabhxyz sourabhxyz merged commit d85f59e into main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants