Feat #65: Improve balance lose check and mention it's details in docs #66
Conversation
sourabhxyz
changed the title
| @@ -49,8 +49,8 @@ over the multi-asset order book to obtain a list of matches. The matches are the | |||
| translated into transactions that will be signed and submitted by the bot. | |||
|
|
|||
| Due to the open and decentralized design of the protocol, anybody can run a Smart Order | |||
| Router instance and collect a share of the fees, thus running a Smart Order Router instance | |||
| is not only contributiung to the further decentralization of the protocol, but it is also | |||
| Router instance and collect the arbitrage opportunities, thus running a Smart Order Router instance | |||
There was a problem hiding this comment.
collect the arbitrage opportunities,
I think we should change the wording here. One does not "collect" opportunities.
There was a problem hiding this comment.
Sorry, could you elaborate / suggest the required changes?
|
Thanks for taking a look @adacapo21! The PR would be merged as soon as it is reviewed from someone else from team. |
You are welcome. Good luck! @sourabhxyz |
|
The proposed changes ensure that there is no Ada loss, even when taking fees into account, when the currency is lovelaces; and that when the trade involves a non-lovelace currency then the Ada loss is only due to fees paid. This seems reasonable to me. |
Closes #65. Also see #62.