-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for SOR using Docker #67
Conversation
Add info on signing key and collateral
4fe9dfa
to
6f96785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a not about the fact that the --testnet-magic 1
must be removed for mainnet.
Otherwise it looks good.
README.md
Outdated
Use the following command to find and select the UTXO to be used for collateral: | ||
|
||
```shell | ||
cardano-cli query utxo --address $(cat bot.preprod.addr) --testnet-magic 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @caike ! Maybe worth mentioning that this information can be conveniently obtained from explorer such as cexplorer.io
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still prefer to add a note about mainnet or two commands: one for preprod and one for mainnet.
Actually.... the default config is for mainnet in other places. Maybe we should stick to mainnet here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with these suggestions. However, the section of the README that shows how to create a wallet is using preprod:
cardano-cli address build \
--payment-verification-key-file bot.vkey \
--testnet-magic 1 \
--out-file bot.preprod.addr
So maybe defaulting to --mainnet
on the query command while using bot.preprod.addr
as the address might be confusing. Thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it seems ok after the update.
Summary
Add information on how to read and assign signing key and collateral for running the SOR using Docker.
Addresses part of Issue #60
Please mark the relevant option(s) for your pull request:
Checklist
Please ensure that your pull request meets the following criteria: