Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new GoaT NLP UI along with seamless streaming between frontend and servers #33
base: main
Are you sure you want to change the base?
Adds new GoaT NLP UI along with seamless streaming between frontend and servers #33
Changes from all commits
3abfcdd
43c77e6
b0ddec5
2727fc8
c770b71
cd314da
80e24dc
a7f98f7
9a06fa5
a4d1502
d67c1f7
42b0542
8cdd7e4
1d29fc1
d9faf5c
88e5736
91186af
32aed93
32dae8d
fe131e8
c55ec68
ffef277
dd95ae1
199cfb6
fa79d73
f93d997
dbab17c
a979244
300c7bd
7761c52
c79a073
32ad9ad
e7fe5e0
f0eef0f
b9fd9e1
a80cf20
e08fe5f
10f88df
5451876
7cef6b6
4cfbf1f
2cd93ed
41cb6fe
4b137f5
62e21dc
72fce9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider providing more context for environment variables
It might be helpful to briefly explain what each environment variable is used for, especially for new contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (documentation): Reconsider ignoring DeprecationWarnings
While ignoring DeprecationWarnings can be useful, it might hide important information. Consider addressing the warnings or explaining why they're being ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using an enum for status values
Using an enum for status values would provide better type safety and prevent potential typos in status strings. It would also make it easier to manage and update the list of possible statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (complexity): Consider simplifying the attribute cleaning logic and streamlining the functions.
While the separation of
identify_attributes
anddefine_attribute_condition
is a step towards better organization, the implementation has introduced unnecessary complexity. Here's a suggestion to simplify while maintaining the separation of concerns:identify_attributes
:define_attribute_condition
:These changes maintain the separation of concerns while reducing nesting and simplifying the logic. The attribute cleaning process is now more concise, and error checking is more consistent between the two functions.