-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuzzy search and general CLI improvements #94
Open
erik-brink
wants to merge
21
commits into
dev
Choose a base branch
from
dev-better-simple-search
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
The What
This pull request introduces several enhancements and new features to the
NGPIris
project, particularly focusing on the CLI and HCP handling functionalities. The most notable changes include adding new search capabilities, improving object listing options, and updating dependencies.Enhancements to CLI functionalities:
NGPIris/cli/__init__.py
: Enhanced the_list_objects_generator
function to support filtering by path and file-only options. Added new options to thelist_objects
command for pagination and file-only output. Introduced a newfuzzy_search
command utilizing the RapidFuzz library for improved search capabilities. [1] [2] [3] [4] [5] [6] [7]Improvements to HCP handling:
NGPIris/hcp/hcp.py
: Updated thelist_objects
method to include filtering by path and file-only options. Refined thedelete_objects
anddelete_folder
methods to handle non-existent objects more gracefully and ensure proper deletion of folders with subfolders. Added a newfuzzy_search_in_bucket
method for fuzzy search functionality using RapidFuzz. [1] [2] [3] [4] [5] [6]Dependency updates:
pyproject.toml
: Updated the project version to5.2.0.dev1
and added theRapidFuzz
library as a new dependency for enhanced search capabilities.The Why
Mostly quality of life changes
This update is:
Tests
pytest
pytype