Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mountain-Bracing Bolt #2249

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Mountain-Bracing Bolt #2249

merged 2 commits into from
Oct 20, 2024

Conversation

clevernt
Copy link
Contributor

  • New weapon package
  • Config in weapon package
  • Run pipeline with added config (generates weapon curve, .generated.json files)
  • Weapon key
  • Shortcuts for weapon key
  • Add weapon package to imports
  • Weapon passive (might include an attack)
  • Update documentation

@clevernt
Mountain-Bracing Bolt
519933d 
add new weapon
@shizukayuki shizukayuki added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Oct 19, 2024
@imring imring merged commit add87b7 into genshinsim:main Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizukayuki shizukayuki shizukayuki left review comments

@imring imring imring approved these changes

Assignees
No one assigned
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clevernt @imring @shizukayuki