Skip to content

Commit

Permalink
Do not exclude handlebars but manage to desired version
Browse files Browse the repository at this point in the history
  • Loading branch information
npomaroli committed Sep 13, 2024
1 parent 901312c commit 1e37fff
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 22 deletions.
13 changes: 4 additions & 9 deletions bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<aws.sdk.version>2.16.83</aws.sdk.version>
<snakeyaml.version>1.30</snakeyaml.version>
<testcontainers.version>1.19.4</testcontainers.version>
<handlebars.version>4.3.1</handlebars.version>
</properties>

<!-- IMPORTANT: Always keep dependencies in-sync with mesh-plugin-parent pom in order to avoid duplicate libraries in shaded plugin jars -->
Expand Down Expand Up @@ -292,12 +293,6 @@
<groupId>io.vertx</groupId>
<artifactId>vertx-web-templ-handlebars</artifactId>
<version>${vertx.version}</version>
<exclusions>
<exclusion>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
Expand Down Expand Up @@ -703,9 +698,9 @@

<!-- Library replacements -->
<dependency>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
<version>4.3.1</version>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
<version>${handlebars.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
Expand Down
4 changes: 0 additions & 4 deletions doc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@
<groupId>io.vertx</groupId>
<artifactId>vertx-web-templ-handlebars</artifactId>
</dependency>
<dependency>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
</dependency>

<!-- Required by SearchModelGenerator -->
<dependency>
Expand Down
5 changes: 0 additions & 5 deletions plugin-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,6 @@
<artifactId>vertx-web-templ-handlebars</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-common</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions verticles/admin-gui/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@
<groupId>io.vertx</groupId>
<artifactId>vertx-web-templ-handlebars</artifactId>
</dependency>
<dependency>
<groupId>com.github.jknack</groupId>
<artifactId>handlebars</artifactId>
</dependency>
</dependencies>

<build>
Expand Down

0 comments on commit 1e37fff

Please sign in to comment.