PB-579: Fix semver bump type from PR title #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BitJonny/[email protected] action had an issue with pull_request events, somehow it returned the last closed PR on the head branch instead of the curren t PR on the head. Because the PR infos required are anyway part of the github pull_request event payload we take it from it now.
If any commit in a PR contains a bump type it was taken instead of the PR bump type set in title or body. This was due to the fact that geoadmin/github-tag-action takes bump type from commit message and we were setting the bump type from the title as default. So now the PR bump type is set as commit message to the local merge commit that is used by geoadmin/github-tag-action to compute the future git tag and bump type.
rebert
approved these changes
Jun 6, 2024
ltshb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any commit of a PR had a bump type in its commit message, we could not overwrite it using the PR title/body of the PR. This issue has been discovered by this PR geoadmin/service-wmts#86 in which the https://github.com/geoadmin/github-tag-action has a bug an try to do a tag that already exist, and to work around this bug I tried to change the bump type from patch (set by a previous commit message) to minor but this did not work due to this bug.
IMPORTANT: https://github.com/geoadmin/github-tag-action bump type is taken by higher ranking, which means if any commit message inside a PR contains #major, you cannot force the bump type to minor or patch.