Drop support for Symfony < 5.4, add Symfony 6.4 and PHP 8.3 to CI #342
Conversation
|
Thanks. Before merging this we should wait for geocoder-php/Geocoder#1184 |
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
from
1c5a07c
to
19a7677
Compare
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
from
19a7677
to
fb28287
Compare
ker0x
changed the title
|
Friendly ping @norkunas! I have rebased my PR and include Symfony 6.4 and PHP 8.3 to the CI matrix ! |
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
2 times, most recently
from
9dd2c51
to
5cdcc2f
Compare
|
Sorry,will be available on wednesday,and will review 🙌 |
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
13 times, most recently
from
70f28d1
to
5c911ef
Compare
|
@norkunas tests are green on my side (https://github.com/ker0x/geocoder-php-geocoder-bundle/actions/runs/7695337920). I will prefer to see this PR merge instead of #350 as there are too many problems with deprecations and Symfony 4.4 |
|
I prefer to make a last release with fixed tests and then dropping support for 4.4 |
ker0x
changed the title
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
6 times, most recently
from
bf60223
to
d226cf4
Compare
.github/workflows/ci.yml
Outdated
| @@ -101,7 +91,6 @@ jobs: | |||
| uses: "ramsey/composer-install@v2" | |||
There was a problem hiding this comment.
Version 3 was released this week. This could be changed to fix node16 => 20 deprecation in ci
|
@ker0x as `geocoder-php/Geocoder release is stalled, I think we can finish/merge this and release which will save us some trouble, because it's too hard to maintain such a broad version range so I had to completely disable 2 CI jobs |
.github/workflows/ci.yml
Outdated
| - php: '7.4' | ||
| sf_version: '5.4.*' | ||
| dependencies: 'lowest' |
There was a problem hiding this comment.
we should probably leave this, only removing 4.4
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
3 times, most recently
from
f3c3c79
to
7ee9558
Compare
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
from
7ee9558
to
a9b0e48
Compare
…date .gitattributes file
ker0x
force-pushed
the
feature/drop-sf-4.4
branch
from
a9b0e48
to
d40fdf6
Compare
This PR drop support for Symfony < 5.4 and add 6.3 to the CI test matrix. It also update the
.gitattributesthat was outdated.