Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup geoserver docker build #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdooper
Copy link
Contributor

@gdooper gdooper commented Dec 1, 2018

Some minor changes to the geoserver build process. No functional changes to the resulting docker image.

Three main changes are made:

  • removing two of the build stages that are unnecessary and possibly confusing
  • unpacking the geomesa accumulo and kafka distribution tar files with docker's ADD command, rather than COPY and RUN tar... commands
  • refactoring geodocker-geoserver/Makefile to make it more consistent with geodocker-accumulo-geomesa/Makefile


${GEOMESA_KAFKA_TARBALL}:
mkdir -p tarballs
cp ${HOME}/.m2/repository/org/locationtech/geomesa/geomesa-kafka-dist_2.11/${GEOMESA_VERSION}/${GEOMESA_KAFKA_DIST} tarballs/.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's better to download this geomesa-accumulo and geomesa-kafka distributions from a publicly available location (e.g. github releases), or from a local build.
@elahrvivaz do you have a preference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check for a local version, and download if it doesn't exist?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, since we cache it locally then we can just download it, but check to see if it's cached already first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants