Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guarded against dividing by N^2=0 #490

Merged
merged 1 commit into from
Dec 5, 2023
Merged

guarded against dividing by N^2=0 #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/Physics/PDE_Coefficients.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,9 @@ Subroutine Polytropic_ReferenceND_General()
! That's fine up to a multiplicative constant which we determine below

nsquared = gravity*ref%dsdr ! N^2 (non-dimensional) up to multiplicative constant
nsquared = nsquared/nsquared(N_R) ! N^2 (non-dimensional) now correct if ND_Inner_Radius .eq. .True.
If (.not. adiabatic_polytrope) Then ! don't divide by zero!
nsquared = nsquared/nsquared(N_R) ! N^2 (non-dimensional) now correct if ND_Inner_Radius .eq. .True.
Endif

! calculate "basal" dissipation number explicitly
Dissipation_Number = (poly_n + 1.0d0)/(poly_n_ad + 1.0d0) * (1.0d0/aspect_ratio) * &
Expand All @@ -743,7 +745,9 @@ Subroutine Polytropic_ReferenceND_General()
ref%density = ref%density/ref%density(1)
ref%temperature = ref%temperature/ref%temperature(1)
gravity = gravity/gravity(1)
nsquared = nsquared/nsquared(1)
If (.not. adiabatic_polytrope) Then ! don't divide by zero!
nsquared = nsquared/nsquared(1)
Endif
ElseIf (ND_Volume_Average) Then ! This is the default
Call Integrate_in_radius(ref%density,norm)
norm = four_pi*norm/shell_volume
Expand All @@ -757,13 +761,11 @@ Subroutine Polytropic_ReferenceND_General()
norm = four_pi*norm/shell_volume
gravity = gravity/norm

Call Integrate_in_radius(nsquared,norm)
norm = four_pi*norm/shell_volume
nsquared = nsquared/norm

Call Integrate_in_radius(nsquared,norm)
norm = four_pi*norm/shell_volume
nsquared = nsquared/norm
If (.not. adiabatic_polytrope) Then ! don't divide by zero!
Call Integrate_in_radius(nsquared,norm)
norm = four_pi*norm/shell_volume
nsquared = nsquared/norm
Endif

! ref%temperature(N_R) is now T_inner/volav(T); gravity(N_R) = g_inner/volav(g)
Dissipation_Number = Dissipation_Number*ref%temperature(N_R)/gravity(N_R)
Expand Down
Loading