Fix container push #530
Merged
Fix container push #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
fix_container_push
branch
from
421f2f1 to
f1fe5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rayleigh automatic docker container build had problems for a while (maybe forever?), because it no longer builds containers with capital letters (like geodynamics/Rayleigh), but instead requires lowercase letter (geodynamics/rayleigh). This PR modifies our automatic build script to create an environment variable (
REPO_NAME_LC) which contains the lowercase repository name (rayleigh) and use that as the docker container name. I tested that it works now on my own repository, see the container images created here: https://hub.docker.com/r/gassmoeller/rayleigh/tagsand here: https://github.com/gassmoeller/Rayleigh/pkgs/container/rayleigh
Once this is merged it will trigger a build run for the official Rayleigh images on
Dockerhub: https://hub.docker.com/r/geodynamics/rayleigh/tags
Github Container Registry: https://github.com/orgs/geodynamics/packages?repo_name=Rayleigh (currently empty)