Add layer browser icon for geotiff #321
Conversation
|
|
|
Integration tests report: appsharing.space |
| @@ -78,12 +78,14 @@ const iconObject = { | |||
| ImageSource: { iconClass: 'fa fa-image' }, | |||
| VideoSource: { iconClass: 'fa fa-video' }, | |||
| ShapefileSource: { iconClass: 'fa fa-file' }, | |||
| GeoTiffSource: { iconClass: 'fa fa-gear' }, | |||
There was a problem hiding this comment.
Gear, as in "cog"? Excellent choice ;)
|
|
||
| RasterLayer: { icon: rasterIcon }, | ||
| VectorLayer: { iconClass: 'fa fa-vector-square' }, | ||
| HillshadeLayer: { icon: moundIcon }, | ||
| ImageLayer: { iconClass: 'fa fa-image' }, | ||
| VideoLayer: { iconClass: 'fa fa-video' }, | ||
| WebGlLayer: { iconClass: 'fa fa-gear' }, |
There was a problem hiding this comment.
Does it make sense to have a dedicated icon for webGL layer? As a user, I don't think this is a meaningful classification. A webGL layer in openlayers can be a raster tile layer or a vector layer. What about showing the raster or vector icons depending on which?
There was a problem hiding this comment.
+1 for a distinct icon for better identification. Since we have a dedicated handling for a webGL layer maybe using this icon could make more sense?
|
I have mixed feelings for the cog icon :D
EDIT: No hard feelings though, if there is a consensus on the COG icon and I'm the only one rethinking it, happy to merge and ignore my doubts 😄 |
QGIS uses a checkerboard looking thing for tiffs, I think that's what it uses for all raster layers. There's been a lot of icon discourse this week 😂 we might want to have a discussion about it. |
Yeah, neither pretty nor recognisable |
Yeah QGIS only differentiates vector and raster layers with icons, and I like the simplicity of that. That said, I agree with @arjxn-py that the QGIS icon for raster isn't super recognizable. For vector, fontawesome has an icon that looks pretty good for vector data: https://fontawesome.com/icons/draw-polygon?s=solid Similar to the checkerboard icon, fontawesome results for "grid": https://fontawesome.com/search?q=grid&o=r Or: https://fontawesome.com/icons/game-board-simple?f=sharp&s=solid ? |
Description
Adds icon for
GeoTiffsources and andWebGlTilelayers in the layer browser.Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--321.org.readthedocs.build/en/321/
💡 JupyterLite preview is available from the doc, by clicking on