Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a couple of options #73

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added a couple of options #73

wants to merge 5 commits into from

Conversation

m4rkw
Copy link
Contributor

@m4rkw m4rkw commented Jan 2, 2018

  • option for Apple Maps format links when using the locate command
  • option for disabling the status LED

@m4rkw m4rkw requested a review from ppescher January 2, 2018 09:57
ppescher
ppescher reviewed Jan 2, 2018
View reviewed changes
Copy link
Contributor

@ppescher ppescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mark!
It looks good. I will test this next week when back to the office. I need to check if these changes play well with power saving options I added recently.

@m4rkw
Copy link
Contributor Author

m4rkw commented Jan 2, 2018

Hey, ok cool. I tested this myself and had some issues with it but not sure if it's related to my changes or the opentracker codebase itself. I reverted back to using my private stripped-down code that's specifically for my use-case and that's working much better. Unfortunately I don't have much time to debug this stuff these days :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppescher ppescher ppescher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4rkw @ppescher