Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

プラグインシステムの改造: 地図のレンダリングの前にパラメータにアクセス可能にする #205

Closed
wants to merge 14 commits into from
Closed

プラグインシステムの改造: 地図のレンダリングの前にパラメータにアクセス可能にする #205

wants to merge 14 commits into from

Conversation

kamataryo
Copy link
Contributor

No description provided.

@kamataryo
Copy link
Contributor Author

TODO: 非同期でのプラグイン実行に対応

@kamataryo kamataryo changed the title Issue 204 plugin hook points プラグインシステムの改造: 地図のレンダリングの前にパラメータにアクセス可能にする May 27, 2021
@kamataryo
Copy link
Contributor Author

kamataryo commented May 27, 2021 •
edited
Loading

#204

変更点:

  • window.geolonia.registerPluginHook という新しい API を作りました。複数のフックポイントを指定できます。現在は2箇所 ('before-map' | 'after-map')
  • async なプラグインにも対応
  • プラグインがクラッシュしても地図のレンダリングを止めない

@kamataryo kamataryo marked this pull request as ready for review May 27, 2021 08:52
@kamataryo kamataryo requested a review from keichan34 May 27, 2021 08:52
@kamataryo kamataryo marked this pull request as draft May 27, 2021 11:19
@kamataryo kamataryo closed this May 28, 2021
@kamataryo kamataryo deleted the issue-204__plugin-hook-points branch May 28, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichan34 keichan34 Awaiting requested review from keichan34

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kamataryo