Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StatusValue.Events to an enum class #8583

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ianwallen
Copy link
Contributor

@ianwallen ianwallen commented Jan 6, 2025

Move StatusValue.Events to an enum class
Identified the media type that is being stored in the database.
Instead of detecting if data is json or xml, instead base it on the media type for the event.

This is mostly a refactoring the code.

This is an enhancement on the changes from #8579

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@ianwallen ianwallen added this to the 4.4.7 milestone Jan 6, 2025
@ianwallen ianwallen marked this pull request as ready for review January 6, 2025 13:15
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good.

@ianwallen would you mind to update the pull request to remove these unused imports from MetadataWorkflowApi?

import org.json.JSONException;
import org.json.JSONObject;

Identified the media type that is being stored in the database.
Instead of detecting if data is json or xml, instead base it on the media type for the event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants