Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byte data to metadata summary page for its children thumbnails #8608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wangf1122
Copy link
Collaborator

The parent metadata can contain large amounts of children record and on its summary page, it displays their thumbnails.
image

The issue was it was url for each of the thumbnail which invokes its resource API and with large volumes of HTTP traffic it will crash the application if the backend database pool is relative small.

This pull request will alter the search service to have the data as part of the children in related records.

image

and these byte data from the search engine can be used to the HTML/Javascript

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.7 milestone Jan 20, 2025
@josegar74
Copy link
Member

I have tested it and it works as described, but the response with 2 children goes from 40kb (which also seems a bit high to me, maybe the fields returned for the relations should be reduced?) to 80kb.

@fxprunayre can you check the pull request too? I know that some users have series with hundreds of children, so this may improve the number of http requests made, but also substantially increase the size of the related query responses.

@wangf1122
Copy link
Collaborator Author

wangf1122 commented Jan 22, 2025

@josegar74

Another option or maybe extra feature to introduce is to have this more button (it only load four records at one time)

image

I checked the UI code and this is some Javascript module for footer.html's but wondering if we can add similar to the related.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants