-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Add a date range search filter #1030
base: main
Are you sure you want to change the base?
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
Thank you @tkohr for this nice date range filter!
While testing the component I was also feeling a need for a "clear filter" button as you already mentioned. But maybe this will be part of future implementation.
Apart from this I only have some minor comments. Let me know if something is not clear.
libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.spec.ts
Show resolved
Hide resolved
libs/feature/router/src/lib/default/state/query-params.utils.ts
Outdated
Show resolved
Hide resolved
libs/ui/inputs/src/lib/date-range-dropdown/date-range-dropdown.component.css
Outdated
Show resolved
Hide resolved
to make them work with other filters
todo: methods should only accept DateRange or string, not both
Co-authored-by: Olivia Guyot <[email protected]>
…range even without the date input, this is used in the calendar display
2693db5
to
f95e16d
Compare
Description
This PR allows setting a date range filter via the calendar.
Open to-dos are:
add a filter reset button while waiting for filter summary?=> wait for Editor: Add a search filters summary component #1037 before merging this oneDisplaying available dates in the calendar via the aggregation values will be part of a separate PR.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label