Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add a date range search filter #1030

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Editor: Add a date range search filter #1030

wants to merge 21 commits into from

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Oct 25, 2024

Description

This PR allows setting a date range filter via the calendar.

Open to-dos are:

Displaying available dates in the calendar via the aggregation values will be part of a separate PR.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, ui-search, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 25, 2024

📷 Screenshots are here!

@tkohr tkohr marked this pull request as ready for review November 6, 2024 10:50
@coveralls
Copy link

coveralls commented Nov 6, 2024

Coverage Status

coverage: 83.709% (-0.03%) from 83.736%
when pulling f95e16d on me-date-filter
into 67cb636 on main.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉
Thank you @tkohr for this nice date range filter!

While testing the component I was also feeling a need for a "clear filter" button as you already mentioned. But maybe this will be part of future implementation.

Apart from this I only have some minor comments. Let me know if something is not clear.

@jahow jahow added this to the 2.4.0 milestone Nov 14, 2024
tkohr and others added 21 commits November 26, 2024 09:18
to make them work with other filters
todo: methods should only accept DateRange or string, not both
…range

even without the date input, this is used in the calendar display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants