Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapstore configuration for 2024.02 #428

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Oct 28, 2024

Description

This PR updates print config that aligns with latest MS stable 2024.02.xx

@landryb
Copy link
Member

landryb commented Oct 28, 2024

thanks @dsuren1 , will you also do a PR to update https://github.com/georchestra/datadir/blob/master/mapstore/configs/localConfig.json with the changes from georchestra/mapstore2-georchestra#715 and georchestra/mapstore2-georchestra#716 ? just to make sure we don't duplicate each other's work..

@landryb
Copy link
Member

landryb commented Oct 28, 2024

for anyone looking at the PR, it adds A2 templates, and most importantly a 'credits' box in all templates which comes from https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/mapstore-migration-guide/#enable-showing-creditsattribution-text-in-print-config (and geosolutions-it/MapStore2#10279 / geosolutions-it/MapStore2#10451)

@landryb
Copy link
Member

landryb commented Oct 28, 2024

thanks, LGTM! that also brings the missing/forgotten commit from georchestra/mapstore2-georchestra@6ba8f3beca40b6 - much appreciated !

@landryb landryb merged commit 77fec0a into georchestra:master Oct 28, 2024
1 check passed
@landryb landryb changed the title Print config updated Update mapstore configuration for 2024.02 Oct 28, 2024
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
Copy link

💚 All backports created successfully

Status Branch Result
docker-master

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot added a commit that referenced this pull request Oct 28, 2024
[docker-master] Update mapstore configuration for 2024.02 (#428)
@landryb
Copy link
Member

landryb commented Oct 28, 2024

note to people who're going to manually merge that to their configs, most of it come from https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/mapstore-migration-guide/#migration-from-20230202-to-20240100

@landryb
Copy link
Member

landryb commented Oct 29, 2024

and another note for the ones who won't remember to update the printing config: you'll get a 500 code on /mapstore/pdf/info.json

Message Error occurred while reading configuration file '/etc/georchestra/mapstore/printing/config.yaml':
java.lang.RuntimeException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException:
Unrecognized field "host" (class org.mapfish.print.config.AddressHostMatcher), not marked as ignorable
(4 known properties: "port", "pathRegex", "mask", "ip"])

or

Error occurred while reading configuration file '/etc/georchestra/mapstore/printing/config.yaml':
java.lang.RuntimeException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException:
Unrecognized field "width" (class org.mapfish.print.config.layout.TextBlock), not marked as ignorable
(12 known properties: "fontSize", "fontEncoding", "vertAlign", "align", "spacingAfter", "renderOnExtraPage",
"condition", "text", "font", "backgroundColor", "asHTML", "fontColor"])

see https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/mapstore-migration-guide/#print-config-file-update for details

landryb added a commit to georchestra/ansible that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants