Fix infinite redirection when path root contains query params #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwanehcine
commented
May 4, 2023
| @@ -108,15 +108,10 @@ services: | |||
| ) | |||
| - "traefik.http.routers.traefik-redirect.priority=10" | |||
| - "traefik.http.routers.traefik-redirect.middlewares=add-trailing-slash@docker" | |||
| - "traefik.http.middlewares.add-trailing-slash.redirectregex.regex=^https?://(.*)/(.+)" | |||
| - "traefik.http.middlewares.add-trailing-slash.redirectregex.regex=^https?://^[^?]+$/(.+)" | |||
…when_path_contains_query_param
|
I have tested this and it works, but I think the regex is misleading. Something like that would be clearer IMO: Here we add a third capturing group containing query params, which we reappend after the trailing slash. What do you think @marwanehcine? |
can you please continue this PR here : #197 |
emmdurin
pushed a commit
that referenced
this pull request
Jun 9, 2023
* rebase from #168 * update traefik redirection rules
emmdurin
pushed a commit
that referenced
this pull request
Jul 11, 2023
* rebase from #168 * update traefik redirection rules
f-necas
pushed a commit
that referenced
this pull request
Feb 19, 2024
* rebase from #168 * update traefik redirection rules
edevosc2c
pushed a commit
that referenced
this pull request
Jun 7, 2024
* rebase from #168 * update traefik redirection rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix infinite redirection when path root contains query params, traefik redirection rules in docker-compose.override.yml has to be updated. A new regex formula is used to check is query param exist or not