Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back SP + disable all not needed services + update rabbitmq healthcheck #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edevosc2c
Copy link
Member

This pull request aims to add back the services that shouldn't entirely be removed, like security-proxy.

This PR has these services disabled by default, thanks to "scale: 0":

  • security-proxy
  • analytics
  • cas
  • rabbitmq

RabbitMQ is not a hard requirement, so there is no point in having it enabled by default.

I have also updated rabbitmq healthcheck because rabbitmq-diagnostics -q check_local_alarms slow down the ability for the service to become healthy.

Copy link
Contributor

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scale's nice but it doesn't it's not obvious than the container isn't start at first look of docker compose file. I prefer comments rather than scale.

@edevosc2c
Copy link
Member Author

Scale's nice but it doesn't it's not obvious than the container isn't start at first look of docker compose file. I prefer comments rather than scale.

Scale doesn't involve git conflicts when the optional service gets its image updated, for example. If you uncomment a service, but we update the image, then you have to resolve the conflict because all the lines have been uncommented on your side.

Also, the "comment" way doesn't make sense for the services that will probably be wanted by a lot of people, like rabbitmq. Very few people want SP, analytics or CAS but rabbitmq a lot of people will need it.

In my opinion, "scale" is solving the issue on both sides. Solving the issue of not running a service by default and make it easy to keep few divergences with the upstream docker composition.

I think what I can do is to reorder the docker-compose file structure.

Like all the required services are ordered first, then you have a comment stating these services are optional, and after you have the group of optional services. Here is an example:

version: "3.1"
volumes:
services:
  required1:
  required2:

# Optional services:

  optional1:
  optional2:

What do you think?

@edevosc2c edevosc2c force-pushed the add-more-disabled-services branch from dc6cf93 to 9a6fe65 Compare November 4, 2024 16:52
@f-necas
Copy link
Contributor

f-necas commented Nov 5, 2024

Ok then to re-order services.

Could you also add geocontrib ? There's already a geocontrib branch with it

@edevosc2c
Copy link
Member Author

Could you also add geocontrib ? There's already a geocontrib branch with it

no geocontrib is not part of the official georchestra stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants