Preserve response headers when redirecting application error to gateway error pages #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay error pages Commit 37ff94b make the `ApplicationError` Gateway filter lose the original response headers when throwing a `ResponseStatusException` for the Gateway to show up the customized HTML error pages instead of the orignal (usually whitelabel) errors. This patch makes it so that the `ApplicationError` filter runs only when `text/html` is accepted by the request, and the request method is idempotent (e.g. GET, HEAD, etc.). Additionally, the original response headers are not lost, since the exception is thrown at `ServerHttpResponseDecorator.beforeCommit()`, and respecting the reactive chain.
edevosc2c
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thank you @groldan.
I just deployed this PR in dev at https://geodata.dev.inrae.fr and this works great!
I'm now using the all default-filters and all the headers are correctly passed on the error pages.
For me it's good to be merged. I didn't review the code, just validated that it fixes the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 37ff94b make the
ApplicationErrorGateway filter lose the original response headers when throwing aResponseStatusExceptionfor the Gateway to show up the customized HTML error pages instead of the orignal (usually whitelabel) errors.This patch makes it so that the
ApplicationErrorfilter runs only whentext/htmlis accepted by the request, and the request method is idempotent (e.g. GET, HEAD, etc.).Additionally, the original response headers are not lost, since the exception is thrown at
ServerHttpResponseDecorator.beforeCommit(), and respecting the reactive chain.Fixes #128