-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize error pages #152
Conversation
I like the '500' -> maintenance shortcut, to avoid saying 'something is badly broken' ;) |
I'd have put a picture of you with your sysadmin teeshirt "like riding a bike, except that everything is in fire and you are in hell" ;-) |
Not sure I fully understand what's at stake here. I think I do not really understand the need for an XHR call to /config. |
It calls the stylesheet (if) set in the datadir in order to customize the error page if wanted. (like colors font etc...). If no stylesheet is set, it just displays this new page with georchestra's colors. |
OK, got it, thanks ! |
Requesting @groldan 's review too |
Almost fell off the bed when I just woke up and saw this notification saying you added a /config route to the gateway. Thought it was exposing the config service. |
…le (logo and stylesheet)
to expose datadir/georchestra style (logo and stylesheet) (cherry picked from commit 9ff030b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
to expose datadir/georchestra style (logo and stylesheet)
I'm not sure about the
/config
route. I did this way in order to let other applications to be able to retrieve config from the gateway.Everything is customizable with the georchestraStylesheet set in default.properties from datadir.
Previews :
In blue :