Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize error pages #152

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Customize error pages #152

merged 3 commits into from
Dec 4, 2024

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Dec 3, 2024

I'm not sure about the /config route. I did this way in order to let other applications to be able to retrieve config from the gateway.

Everything is customizable with the georchestraStylesheet set in default.properties from datadir.

Previews :
image

image

In blue :
image

@landryb
Copy link
Member

landryb commented Dec 3, 2024

I like the '500' -> maintenance shortcut, to avoid saying 'something is badly broken' ;)

@pmauduit
Copy link
Member

pmauduit commented Dec 3, 2024

I like the '500' -> maintenance shortcut, to avoid saying 'something is badly broken' ;)

I'd have put a picture of you with your sysadmin teeshirt "like riding a bike, except that everything is in fire and you are in hell" ;-)

@fvanderbiest
Copy link
Member

fvanderbiest commented Dec 3, 2024

Not sure I fully understand what's at stake here.
Would you be able to develop in the PR description what it does and why ?
Ideally, people should not have to read the code to understand what the PR does ;-)

I think I do not really understand the need for an XHR call to /config.

@f-necas
Copy link
Collaborator Author

f-necas commented Dec 3, 2024

It calls the stylesheet (if) set in the datadir in order to customize the error page if wanted. (like colors font etc...).

If no stylesheet is set, it just displays this new page with georchestra's colors.

@fvanderbiest
Copy link
Member

OK, got it, thanks !

@fvanderbiest fvanderbiest requested a review from groldan December 3, 2024 08:52
@fvanderbiest
Copy link
Member

Requesting @groldan 's review too

@groldan
Copy link
Member

groldan commented Dec 3, 2024

Almost fell off the bed when I just woke up and saw this notification saying you added a /config route to the gateway. Thought it was exposing the config service.
Please be more specific 😀, like in "Add a custom entry point to retrieve the error pages stylesheet..." or so. Same for the commits, it doesn't say much and commits arre independent of GitHub.
Other than that great work.

@f-necas f-necas merged commit 9ff030b into main Dec 4, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
  to expose datadir/georchestra style (logo and stylesheet)

(cherry picked from commit 9ff030b)
Copy link

github-actions bot commented Dec 4, 2024

💚 All backports created successfully

Status Branch Result
1.1.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

f-necas added a commit that referenced this pull request Dec 4, 2024
  to expose datadir/georchestra style (logo and stylesheet)
f-necas added a commit that referenced this pull request Dec 4, 2024
[1.1.x] feat: add a style-config entrypoint (#152)
@f-necas f-necas deleted the error-page-design branch December 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants