preauth - being able to receive base64-encoded headers #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmauduit
force-pushed
the
preauth-base64-decode-headers
branch
from
bbe213c to
f016c40
Compare
|
Updated / force-pushed to take into account @groldan 's feedback: instead of setting a new configuration property, we can assume that if the the header's value is prefixed with Also updated the doc / apache2 mod_mellon configuration example. |
|
@groldan ready for review |
As Netty will always consider received headers as US-ASCII encoded, this can lead to issues when the values contain accented characters. With this new feature, it is possible to consider the values as base64-encoded, which will be decoded before use. Tests: IT added.
groldan
force-pushed
the
preauth-base64-decode-headers
branch
from
f016c40 to
8485235
Compare
groldan
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Netty will always consider received headers as US-ASCII encoded strings, this can lead to issues when the values contain accented characters.
With this new feature, it is possible to consider the headers values as base64-encoded, which will be decoded before use.
Tests: IT added.