Updated OAuth2 provider and organization fields in account creation e-mails #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwanehcine
force-pushed
the
updated_oauth2_and_org_fields_in_creation_emails
branch
from
42f41fa to
2b9a67b
Compare
marwanehcine
force-pushed
the
updated_oauth2_and_org_fields_in_creation_emails
branch
from
2b9a67b to
fe3924f
Compare
pmauduit
reviewed
Jan 10, 2024
There was a problem hiding this comment.
I did not get what was the intent behind the PR, I assume it is to add some extra information to the message sent via rabbitMQ, so that the console can use these infos when sending a notification when an account is created ?
About the oauth2providerId, is it a convention to have a string with a semicolon, so that we can be sure we will be able to split the string on this character ?
...java/org/georchestra/gateway/accounts/events/rabbitmq/RabbitmqAccountCreatedEventSender.java
Outdated
Show resolved
Hide resolved
pmauduit
approved these changes
Jan 11, 2024
|
As discussed this morning, it may deserve 2 different fields instead of splitting the oauth2ProviderId variable |
pmauduit
approved these changes
Jan 16, 2024
This can be revisited later on, LGTM then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending User Details including provider name and provider Uid and organization to console when creating a new OAuth2 account.