Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure replicas, as discussed in #42 #69

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Configure replicas, as discussed in #42 #69

merged 4 commits into from
Nov 22, 2023

Conversation

jeanpommier
Copy link
Member

Allows to turn off some apps, for instance for maintenance operations

see #42

Allows to turn off some apps, for instance for maintenance operations
#42
@edevosc2c
Copy link
Member

edevosc2c commented Nov 21, 2023

I think instead of | default 1, just uncomment replicas: 1 in the values.yaml, then 1 will always be used "by default".

Could you name the helm value replicaCount instead of replicas? It's a standard in the "Kubernetes world": https://www.automox.com/blog/kubernetes-helm-101 and https://helm.sh/docs/chart_template_guide/getting_started/

Thank you

@jeanpommier
Copy link
Member Author

Fine by me. Done. Thanks for the review

@edevosc2c edevosc2c merged commit b044168 into main Nov 22, 2023
@edevosc2c edevosc2c deleted the replicas branch November 22, 2023 10:04
@edevosc2c edevosc2c added the enhancement New feature or request label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants