Remove usage of emptyDir for datafeeder upload #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed by @pmauduit on slack that it's not worth to keep.
I created a separate issue here: georchestra/georchestra#4140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't make sense to use an emptyDir for that because the ephemeral filesystem of the container is already enough.
It's also using precious emptyDir disk space.
In the future, maybe useful to allow this to be configured in order to for example use a PVC so that it doesn't use the local disk space. Not sure if this directory is just for "temporary" files and these files are immediately deleted once the import is done.