Set georchestra gateway by default #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpommier
approved these changes
Jun 6, 2024
|
No, we will do yet another release. And I won't merge until gateway is by default in georchestra/docker. |
|
OK. It should match with at least a minor version number IMO, since this is not a benign design change |
|
Ok, I'll add it in 1.0.1 with a disclaimer that 1.0.0 should be skipped and that 1.0.0 will be a switch to georchestra gateway. |
|
Seems fit, yes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docker compose we set to enable gateway by default but with the ability to still use security-proxy: georchestra/georchestra#3881 (comment)
So in Kubernetes we will do the same.