Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated pkg_resources.resource_filename with importlib_res… #5

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

georgkrause
Copy link
Owner

…ources.files

Copy link

github-actions bot commented Feb 27, 2024

Test Results

5 files  5 suites   1m 31s ⏱️
1 tests 1 ✅ 0 💤 0 ❌
5 runs  5 ✅ 0 💤 0 ❌

Results for commit ccf5a89.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

Package Line Rate Complexity Health
. 18% 0
. 18% 0
. 19% 0
. 18% 0
. 18% 0
Summary 19% (282 / 1520) 0

@georgkrause georgkrause force-pushed the 3-pkg_resources branch 2 times, most recently from ccf5a89 to 5b8021b Compare February 28, 2024 10:06
@georgkrause
Copy link
Owner Author

Considering this will break compatibility with python 3.8 this has to wait until October this year.

@ddorian
Copy link

ddorian commented Apr 9, 2024

Considering this will break compatibility with python 3.8 this has to wait until October this year.

Maybe support both ways like many projects do?

@georgkrause
Copy link
Owner Author

Maybe support both ways like many projects do?

I am not sure what exactly you mean. Both python versions or both code versions?

From my perspective all current python versions are supported with the current implementation.
Supporting both versions of the code introduces a complexity and I don't see any reason to do that when we can just wait for a few months.

@georgkrause georgkrause merged commit 7091ccd into main Nov 19, 2024
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants